Eyvind Bernhardsen <eyvind.bernhardsen@xxxxxxxxx> writes: >> + if (!core_ll_merge_double_convert) >> + return sha_eq(o_sha, a_sha); > > I would rather do this: > > if (sha_eq(o_sha, a_sha)) > return 1; > if (!core_ll_merge_double_convert) > return 0; You are absolutely right. This part of my patch was an unnecessary pessimization. Will fix. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html