Re: [PATCH] t/t9700/test.pl: don't access private object members, use public access methods

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/28/2010 09:19 PM, Ævar Arnfjörð Bjarmason wrote:
> On Mon, Jun 28, 2010 at 22:51, Brandon Casey <casey@xxxxxxxxxxxxxxx> wrote:
>> From: Brandon Casey <drafnel@xxxxxxxxx>
>>
>> This test is accessing private object members of the Test::More and
>> Test::Builder objects.  Older versions of Test::More did not implement
>> these variables using a hash.
>>
>> My system complains as follows:
>>
>>   Can't coerce array into hash at <snip>/t/t9700/test.pl line 13.
>>   BEGIN failed--compilation aborted at <snip>/t/t9700/test.pl line 15.
> 
> Just for the record, what version of Test::More is that:
> 
>     perl -MTest::More -le 'print $Test::More::VERSION'

0.47 which is available on RHEL 4.X

>> There are public access methods available for retrieving and setting these
>> variables, so let's use them instead.
>>
>> Signed-off-by: Brandon Casey <casey@xxxxxxxxxxxxxxx>
> 
> This looks good, sorry for the API mistake on my part.

No problem.

-brandon
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]