On Mon, Jun 28, 2010 at 02:12, Bert Wesarg <bert.wesarg@xxxxxxxxxxxxxx> wrote: > On Mon, Jun 28, 2010 at 10:59, Jeff King <peff@xxxxxxxx> wrote: >> On Mon, Jun 28, 2010 at 09:01:57AM +0200, Bert Wesarg wrote: >> >>> 'git notes copy' dumps core when no arguments are given. >> >> How about: > > Thanks. > > Tested-by: Bert Wesarg <Bert.Wesarg@xxxxxxxxxxxxxx> > > FWIW, here is the correct and updated test for this: > > -- >8 -- > Subject: [PATCH] notes: add test for git-notes copy with too few arguments > > Signed-off-by: Bert Wesarg <bert.wesarg@xxxxxxxxxxxxxx> > --- > t/t3301-notes.sh | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/t/t3301-notes.sh b/t/t3301-notes.sh > index 64f32ad..dcd962a 100755 t/t3301-notes.sh > --- a/t/t3301-notes.sh > +++ b/t/t3301-notes.sh > @@ -1044,4 +1044,9 @@ test_expect_success 'GIT_NOTES_REWRITE_REF > overrides config' ' > git log -1 > output && > test_cmp expect output > ' > + > +test_expect_success 'git notes copy does not segfaults with too few > arguments' ' > + test_must_fail git notes copy > +' > + > test_done > Minor nit: s/does not segfaults/does not segfault/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html