Dear diary, on Tue, Oct 24, 2006 at 09:33:12AM CEST, I got a letter where Jakub Narebski <jnareb@xxxxxxxxx> said that... > Petr Baudis wrote: > > > This makes the multiple search types actually usable by the user; > > if you don't read the gitweb source, you don't even have an idea > > that you can write things like that there. > > This is I think good change, although I'm not sure if I like changing > using search operators to using additional CGI parameter. > > Having help page for search is _certainly_ very good change. Perhaps > we should put it out-of-line, not embedded? Just a thought... You mean out-of-file? I've pondered it but I think this is simpler than having yet another external file with yet another configuration option, and the help file is not anyway likely something you will want to customize per-site. > This patch changes search box into something similar to Google > "Advanced Search". Yet Google "Advanced Search" box generates search > query using search operators. Search operators are just more powerfull. > I know that gitweb doesn't use this power now (it uses only one operator, > first if I remember correctly), but we can do this in the future > (e.g. searching for both author and specified string in commit message, > or searching for given author OR given committer). Well, we can always > change it back... Well, yes, that's something we can do when we actually implement the operators, but I think doing it this way is less powerful, but much more *useful* since users not familiar with gitweb will have an actual idea on how to use it, and gitweb is something that will have 90% of users not familiar with it. So perhaps have an "extended" search type which will accept the keywords? -- Petr "Pasky" Baudis Stuff: http://pasky.or.cz/ #!/bin/perl -sp0777i<X+d*lMLa^*lN%0]dsXx++lMlN/dsM0<j]dsj $/=unpack('H*',$_);$_=`echo 16dio\U$k"SK$/SM$n\EsN0p[lN*1 lK[d2%Sa2/d0$^Ixp"|dc`;s/\W//g;$_=pack('H*',/((..)*)$/) - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html