Hi Jonathan, This specific patch is clear. I have some issues with some of the other parts in the series. Jonathan Nieder wrote: > approxidate() is not appropriate for reading machine-written dates > because it guesses instead of erroring out on malformed dates. > parse_date() is less convenient since it returns its output as a > string. So export the underlying function that writes a timestamp. Right. I couldn't justify exposing it in the series that's in master now. > While at it, change the return value to match the usual convention: > return 0 for success and -1 for failure. Since I'm to blame for this change, Acked-by: Ramkumar Ramachandra <artagnon@xxxxxxxxx> -- Ram -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html