Pascal Obry <pascal.obry@xxxxxxxxx> writes:
> When using the protocol git+ssh:// for example we do not want to
> decode the '+' as a space. The url decoding must take place only
> for the server name and parameters.
>
> This fixes a regression introduced in 9d2e942.
> ---
> url.c | 19 +++++++++++++++----
> 1 files changed, 15 insertions(+), 4 deletions(-)
>
> Ok, so this is the fourth version of this patch. Thanks again Matthieu
> for the review. I think this time I got the place for the message
> right :)
Hmm, what's so unclear in "between the --- (tripple) and the
diffstat." ;-) ? (especially the "between" part)
> + /* Skip protocol if present. */
> + if (with_protocol) {
> + first_slash = strchr(*query, '/');
> +
> + while (q < first_slash)
> + strbuf_addch(&out, *q++);
> + }
Nothing personal, but you messed up indentation. Git indents with tabs
(8 chars width), not 2 spaces.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html