Pascal Obry <pascal@xxxxxxxx> writes:
> --
> 1.7.1.524.g6df2f
>
> Ok, given Matthieu comments here is another version of the patch which
> should apply cleanly
> and won't clobber log message with my comments!
Thanks for making the life of our maintainer easier :-).
Unfortunately, it's still not the right place for comments ;-). That's
OK with Git AFAICT, but readers expect them between the --- (tripple)
and the diffstat.
Unless I missed something, this version doesn't address my earlier
comment:
Matthieu Moy <Matthieu.Moy@xxxxxxxxxxxxxxx> writes:
> Pascal Obry <pascal@xxxxxxxx> writes:
>
>> @@ -70,9 +70,18 @@ static int url_decode_char(const char *q)
>> static char *url_decode_internal(const char **query, const char *stop_at)
>> {
>
> This function is called from multiple places :
[...]
> I don't think you want to avoid escaping until the first slash in
> url_decode_parameter_name and url_decode_parameter_value. I think you
> want to patch url_decode, not url_decode_internal.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html