On Sat, Jun 19, 2010 at 04:52, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes: > >> Sun Studio 12 Update 1 thinks that *t could be uninitialized, >> ostensibly because it doesn't take rewrite_cmd into account in its >> static analysis. > > Hmm, I am wondering if I should apply this or just tell you to fix your > compiler ;-) I just noticed it when testing on Solaris, I don't use it regularly. IIRC pretty much exactly the same changes were proposed for compatibility with HP/UX a while back, and looking through the source it seems a lot of things initialize struct pointers to NULL. Although I haven't found any examples yet where they strictly didn't have to. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html