On 06/18/2010 03:29 PM, Erik Faye-Lund wrote: > 2010/6/18 Török Edwin <edwintorok@xxxxxxxxx>: >> readdir() used to do a single pass, which is not always enough. >> If you unlink some files/rmdir some subdirs then there might be some >> files you haven't seen yet *before* the readdir cursor (files get rearranged >> in the directory, etc.). >> >> The fix is to do an additional readdir() pass if we unlinked/rmdired something. >> This is easily accomplished by using rewinddir. >> > > Won't this break on Windows? mingw_readdir() doesn't seem to have a > maching mingw_rewinddir() in compat/mingw.c/h.... > rewinddir() is used in ClamAV too, and it builds natively on win32. I think we have some compat function that map rewinddir to the Win32 API, somebody will probably have to do that for git too. Another possibility is to do closedir/opendir again on mingw. Best regards, --Edwin -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html