On 22:33 Sun 13 Jun , Junio C Hamano wrote:
> Zhang Le <r0bertz@xxxxxxxxxx> writes:
>
> > diff --git a/builtin/mailinfo.c b/builtin/mailinfo.c
> > index 4a9729b..73f51f3 100644
> > --- a/builtin/mailinfo.c
> > +++ b/builtin/mailinfo.c
> > @@ -830,6 +831,8 @@ static int handle_commit_msg(struct strbuf *line)
> >
> > static void handle_patch(const struct strbuf *line)
> > {
> > + if (recode_patch)
> > + convert_to_utf8(line, charset.buf);
>
> builtin/mailinfo.c: In function 'handle_patch':
> builtin/mailinfo.c:835: error: passing argument 1 of 'convert_to_utf8' discards qualifiers from pointer target type
>
> I do not think there is a reason for "line" to be const anymore; it used
> to make sense back when handle_patch() was only about writing the patch
> out, but that no longer is the case.
So you have used -Werror, right?
Because my gcc (4.4.3) only shows a warning.
Will fix it.
My gcc also shows another warning:
builtin/mailinfo.c:836: warning: ignoring return value of 'fwrite', declared
with attribute warn_unused_result
Does it occur to you as well?
--
Zhang, Le
Gentoo/Loongson Developer
http://zhangle.is-a-geek.org
0260 C902 B8F8 6506 6586 2B90 BC51 C808 1E4E 2973
Attachment:
pgpiejebQQNft.pgp
Description: PGP signature