Re: [PATCH v3 0/4] Teach 'git grep' about --open-files-in-pager=[<pager>]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Johannes Schindelin wrote:

> But in my tests, it just does not work 
> on multi-core machines without the patch.

Did you try the v2 series I sent earlier?  I tested it on a machine
with two multi-core CPUs.

Now that I’ve read your patch, though, I don’t want to go back.  The
code duplication in the v2 series was ugly and did not leave the door
open to easily adding threading support later, because it ran the
pager _before_ waiting for pending threads.  And besides, the "Unify
code paths" patch contains an important fix for grep without -O.

Thanks for both patches.
Jonathan
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]