On Mon, 23 Oct 2006, Jim Meyering wrote: > > This removes trailing blanks from git-generated diff headers > the same way a similar patch did that for GNU diff: NO! This is _wrong_ You should only remove the space IF IT IS THE ONLY THING ON THE WHOLE LINE! You must not remove white-space in general. So the patch should check something like if (len == 1 && rec[0] == ' ') len = 0; and not like you did it. Otherwise the patch will simply not even _apply_. Linus - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html