Sverre Rabbelier venit, vidit, dixit 09.06.2010 23:28: > Heya, > > On Wed, Jun 9, 2010 at 23:24, Brandon Casey <casey@xxxxxxxxxxxxxxx> wrote: >> The following python 2.5 features were worked around: > > Thanks for fixing this, although it makes me sad to see the code > uglify the way it has :P. I guess that's the pain of backwards > compatibility. > I doesn't need to be ugly. Why not put the Popen thing in a def somewhere? Is there any remaining uglyness besides this: - return any(url.startswith(i) for i in prefixes) + for prefix in prefixes: + if url.startswith(prefix): + return True + return False Pythonish version: - return any(url.startswith(i) for i in prefixes) + return True in (url.startswith(i) for i in prefixes) Note that due to the use of an iterator (which P2.4 has) rather than a list or set, the expression is just as efficient, i.e. calls startswith() only as often as necessary. Michael -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html