In git-cherry.sh: if test -f "$patch/$2" then sign=- else sign=+ fi Documentation says 'If the change seems to be in the upstream, it is shown on the standard output with prefix "+"', however the above does the reverse. When the file $patch/$2 exists it is because the patch /is/ in upstream so the sign should be "+". Signed-off-by: Andy Parkins <andyparkins@xxxxxxxxx> --- git-cherry.sh | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/git-cherry.sh b/git-cherry.sh index 8832573..1cc48e8 100755 --- a/git-cherry.sh +++ b/git-cherry.sh @@ -71,9 +71,9 @@ do then if test -f "$patch/$2" then - sign=- - else sign=+ + else + sign=- fi case "$verbose" in t) -- 1.4.2.3 - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html