On Tue, Jun 8, 2010 at 2:35 AM, Jeff King <peff@xxxxxxxx> wrote: > If you are downloading a binary, the package compiler should do one of > two things: > > 1. indicate a package dependency on 'less' > but... git will be uninstalled if you happen to uninstall less. > 2. set DEFAULT_PAGER to 'more' (or whatever is appropriate for your > system) > and I know it's a very nice fallback default, but you still depending on the pager, and will display nothing and return 0 if 'more' fails to execute. Something needs to be changed... if the sane way is to keep default pager (almost setting 'more') instead of auto-detection... then we must say something to the user when the pager fails to execute. (*) Actually 'git' display nothing... and returns 0. > Yes, auto-detection means we can more flexibly "upgrade" to less when > the package suddenly appears. But if you really care about your pager, > why not just set $PAGER? > good point, I agree. But again, back to (*), we must correct something... the other way is that if pager fails to execute, we cannot simply return 0. I could submit a patch for this, may be is a little bit better (or simpler). -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html