Hi Junio and Shawn, Shawn O. Pearce wrote: > I would strongly suggest finding another way to implement the SVN > exporter, without using MAP_SHARED. David has already started working on using realloc + persist, but I'd like to know the reason for your recommendation- is it simply because mmap with MAP_SHARED is difficult to port, or is there some other reason as well? Junio C Hamano wrote: > I don't think we _dropped_ a _working_ support that allowed shared > mapping. IIRC the implementation emulated only private mapping well > enough to support the use of mmap() in our codebase (iow, instead of > allocating a buffer and reading into it and possibly mucking with it > without affecting outside world, map it to read and then possibly mucking > with it), but lacked input validation to make sure that no caller > mistakenly thinks the implementation could satisfy non private mapping. Ah, so you did it for safety/ sanity reasons back then. > Also I don't think I did this without telling other people---it would be a > lot more likely that somebody else noticed it and the issue was discussed > on the list and resulted in this commit. I would check the commit date > and see the discussion around that time if I were you to learn the > backstory. Right. Thanks for this- I read the "First cut at git port to Cygwin" thread and learnt the backstory. -- Ram -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html