On 06/06/2010 06:10 PM, Jeff King wrote:
On Sat, Jun 05, 2010 at 01:39:50PM -0400, Mark Levedahl wrote:
- if (!no_verify&& run_hook(index_file, "pre-commit", NULL))
+ if (!no_verify&& run_hook(index_file, "pre-commit", amend ? "amend" : "normal", NULL))
[...]
- against=HEAD
+ if test "$1" = "amend"
+ then
+ against=HEAD~1
+ else
+ against=HEAD
+ fi
Is there a reason to use the magic "amend" and "normal" words, if
scripts are just going to end up changing them back into HEAD~1 and HEAD
anyway?
-Peff
Well, git-gui's internal $commit_type variable has the values
normal|amend, so I went with those. So , yes there is a reason, but
maybe not a great one :^). Given some consensus, this is trivial to
change. I'll let things cook a while longer before sending a new patch.
Mark
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html