On Fri, Jun 04, 2010 at 11:53:20AM -0400, Benjamin C Meyer wrote:
> Perforce branch names with spaces (and other special characters) were
> causing issues.
> [...]
> - details = p4Cmd("branch -o %s" % info["branch"])
> + details = p4Cmd("branch -o \"%s\"" % info["branch"])
Won't this still fail if your branch name contains quotation marks or
backslashes? Does python have some equivalent to perl's quotemeta to
just shell-escape the problematic characters (or even a way of just
using a straight list in p4Cmd and avoiding the shell altogether)?
I know those characters may not be common, but if we are going to quote,
perhaps we should make it foolproof.
-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html