Re: [RFC/PATCH 2/4] textconv: make diff_options accessible from blame

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Junio C Hamano <gitster@xxxxxxxxx> writes:

> Axel Bonnet <axel.bonnet@xxxxxxxxxxxxxxx> writes:
>
>> Diff_options specify whether conversion is activated or not. Blame needs
>> to access these options in order to concert files with external drivers
>>
>> Signed-off-by: Diane Gasselin <diane.gasselin@xxxxxxxxxxxxxxx>
>> Signed-off-by: Clément Poulain <clement.poulain@xxxxxxxxxxxxxxx>
>> Signed-off-by: Axel Bonnet <axel.bonnet@xxxxxxxxxxxxxxx>
>
> The name of Clément is spelled correctly on the mail header while S-o-b
> line is corrupt.

Actually, it's valid UTF-8, but there's no header specifying the
encoding in the email, therefore, the reader's default applies. My
mailer displays it correctly, but yours doesn't.

> Perhaps you have recorded your commits in UTF-8 but allowed your MUA
> to send in 8859-1?

The MUA seems to be git-send-email. According to the source (I didn't
find it in the doc), git-send-email looks at the patch's headers to
specify the encoding.

On my machine, the patch applies well, and if I re-export it using
format-patch, I do get the headers:

Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

If I send myself the patch with git-send-email, I also get the headers
in the email (I tried from ensibm, which is the machine which sent the
patch serie). So, it doesn't look like a bug in git, but rather a
miss-use.

Axel, can you give us the exact command(s) you used to send the patch?

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]