Alex Riesen <raa.lkml@xxxxxxxxx> writes: > On Thu, May 27, 2010 at 20:05, Shawn O. Pearce <spearce@xxxxxxxxxxx> wrote: >> Ilari Liusvaara <ilari.liusvaara@xxxxxxxxxxx> wrote: >>> * Where algorithm in git_revpool_table__hash() is from? Since it appears to >>> hash binary object IDs, wouldn't just simple sum/xor over words be sufficient >>> (all SHA-1 output bits are very nearly independent). Or do you need to be >>> compatible with some other implementation (doesn't appear so, because hash >>> is computed differently depending on endianess)? >> >> If you need a hash value for a SHA-1, why not just cast the unsigned >> char* to unsigned int* and load the first int as the hash code? >> The output of SHA-1 is pretty evenly distributed, using the first >> few bytes as an int should yield a sufficient distribution throughout >> the hashtable. > > Just make sure the SHA1 data are properly aligned for your platform Also I'd prefer to see the code watch out for reproducibility across platforms with different endianness and integer size. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html