Jakub Narebski <jnareb@xxxxxxxxx> writes: > On Tue, 1 June 2010, Pavan Kumar Sunkara wrote: > >> Export gitwebdir variable so that when user types the command >> 'make install-gitweb', gitweb is installed in $(sharedir)/gitweb >> rather than /var/www/cgi-bin. Now, $(sharedir)/gitweb is default >> for both 'install' and 'install-gitweb' targets. >> >> Remove 'gitwebdir=$(gitwebdir_SQ)' from gitweb part of 'install' >> target which is unneccessary now. >> >> Signed-off-by: Pavan Kumar Sunkara <pavan.sss1991@xxxxxxxxx> > > For what it is worth: > > Acked-by: Jakub Narebski <jnareb@xxxxxxxxx> > > (But I have not tested it!) I am wondering if we would also want to do something with this line gitwebdir ?= /var/www/cgi-bin in gitweb/Makefile. This is orthogonal to the patch under discussion does, though. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html