Christian Couder wrote: > diff --git a/builtin/revert.c b/builtin/revert.c > index 5df0d69..9085894 100644 > --- a/builtin/revert.c > +++ b/builtin/revert.c > @@ -530,7 +530,7 @@ static int revert_or_cherry_pick(int argc, const char **argv) > args[i++] = defmsg; > } > args[i] = NULL; > - return execv_git_cmd(args); > + return run_command_v_opt(args, RUN_GIT_CMD); > } > free_message(&msg); > free(defmsg); Doesn’t this leak msg and defmsg? Maybe it would make sense to free the in-core copy of the commit message before the if (!no_commit) block. int ret; ... ret = 0; free_message(&msg); if (!no_commit) ret = commit_for_cherry_pick(signoff, edit, defmsg); free(defmsg); return ret; Jonathan -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html