Hi Christian,
Excellent feature to work on- I've wanted to cherry pick a range several times.
Christian Couder wrote:
> -static int revert_or_cherry_pick(int argc, const char **argv)
> +static int do_pick_commit()
> {
> unsigned char head[20];
> struct commit *base, *next, *parent;
Is there a better way to do this instead of allocating memory for each
commit? When you cherry pick a lot of commits, it might make sense to
use a shared memory pool.
> + /* this is copied from the shell script, but it's never triggered... */
> + if (action == REVERT && !no_replay)
> + die("revert is incompatible with replay");
If it's here for historical reasons, why don't you remove it now?
-- Ram
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html