Jakub Narebski <jnareb@xxxxxxxxx> wrote: > + open my \$access_log_fh, '>', "\$logdir/access.log" > + or die "Couldn't open access log '\$logdir/access.log': \$!"; > + open my \$error_log_fh, '>', "\$logdir/error.log" > + or die "Couldn't open error log '\$logdir/error.log': \$!"; I believe '>>' (append) is preferable for log files and matches the behavior of all other servers. Other than that everything else looks good. I can make that change myself + Ack + push for Junio. -- Eric Wong -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html