Giuseppe Scrivano venit, vidit, dixit 24.05.2010 22:51: > Hello Michael, > > > Michael J Gruber <git@xxxxxxxxxxxxxxxxxxxx> writes: > >> I haven't checked whether this covers all code paths but other than that >> it looks OK to me, and the tests pass. > > is the patch ready for inclusion? You're the author, you should know ;) Note that I can't include your patch. That's up to Junio, and he's been lagging back for good reasons (as you could read on the list) and is in the process of keeping up. I gave you my partial ack'ed-by (see above) and a homework problem to answer: Have you checked whether this covers all code paths (all help/usage callers)? If yes then it's a good idea to resend v2 of your patch as a reply to this thread but with subject "[PATCH v2]..." as it is hard to find otherwise, and cc to Junio. Cheers, Michael -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html