On 05/04/2010 05:47 PM, Scott R. Godin wrote:
Hadn't seen any response to this so I'm reposting in the hopes that this
will make it to the next release.
On 04/01/2010 01:27 PM, Junio C Hamano wrote:
I however think the patch probably "fixes" the issue at the worst point.
Wouldn't either of these alternatives be better?
(1) Perhaps the caller of "pre-commit/post-merge/post-checkout" hook
should instead refresh the index when the hook returns, _iff_ we
expect that majority of these hooks are used to munge the work tree
or the index; or
(2) Because you already established that setgitperms script is the
culprit that leaves the index unrefreshed, instead of forcing all the
callers of the script, it should do the refresh for its callers
before it exits.
Good call.
I talked it over with Todd Zullinger and he came up with the following
patch, which I tested on my end to my complete satisfaction, rebases and
merges go smoothly.
it's still necessary however, to --no-commit on merges so that you can
fix the permissions before your umask blots them out and they wind up in
the commit and saved in the gitmeta file
As a result, my usual modus operandi currently is:
git checkout master
git merge --no-ff --no-commit develop
find . -perm 0600 -or -perm 0700 |grep -v .git/
...fix perms back to where they should be
git add -A
git commit
which is somewhat less than optimal, but otherwise setgitperms.perl is
doing what it should.
Revised patch follows:
--8<--
Subject: [PATCH] Revise setgitperms.perl to fix dirty tree problem when
rebasing/merging
reference:
http://comments.gmane.org/gmane.comp.version-control.git/142548
Note that it will be necessary to not only copy the changed
setgitperms.perl from /usr/share/git-core/contrib/hooks/ to
/usr/share/git-core/templates/hooks/ but additionally every git
repository you currently use this script with, will also need to be
updated with the new version. This process is regrettably not automatic
simply
because git was updated on your system.
---
contrib/hooks/setgitperms.perl | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/contrib/hooks/setgitperms.perl
b/contrib/hooks/setgitperms.perl
index a577ad0..e571560 100644
--- a/contrib/hooks/setgitperms.perl
+++ b/contrib/hooks/setgitperms.perl
@@ -91,6 +91,10 @@ if ($write_mode) {
}
}
close IN;
+
+ # Make sure the index isn't left dirty
+ # http://comments.gmane.org/gmane.comp.version-control.git/142548
+ system("git update-index --refresh");
}
elsif ($read_mode) {
# Handle merge conflicts in the .gitperms file
--
(please respond to the list as opposed to my email box directly,
unless you are supplying private information you don't want public
on the list)
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html