Re: [PATCH v5 01/18] Makefile: pass CPPFLAGS through to fllow customization

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 14, 2010 at 10:58:32AM +0000, Gary V. Vaughan wrote:
> As a matter of fact, Automake even jumps through hoops with
> AM_CPPFLAGS to make sure that the package maintainer doesn't
> accidentally trample over the package builder's CPPFLAGS settings - I
> can't think of a scenario where the person who writes the build system
> for a package knows more about what CPPFLAGS the person who builds it
> will need that the person doing the actual building.
AM_CFLAGS != AM_CPPFLAGS. My concern was the mixing of them.

IIRC the correct direction was that all CPPFLAGS should be valid CFLAGS,
but not all valid CFLAGS are valid CPPFLAGS (depending on your cpp, they
might be passed to other layers).

> I'm pretty sure I'm missing the point though, since letting the
> package builder choose their own CPPFLAGS has been at the core of
> building Unix packages for as long as I can remember...
As a middle ground:
CFLAGS = $(OPTCFLAGS) -Wall
CPPFLAGS = $(OPTCPPFLAGS)
LDFLAGS = $(OPTLDFLAGS)
CC = $(OPTCC)
AR = $(OPTAR)

(and pass them suitably to the various binaries).

-- 
Robin Hugh Johnson
Gentoo Linux: Developer, Trustee & Infrastructure Lead
E-Mail     : robbat2@xxxxxxxxxx
GnuPG FP   : 11AC BA4F 4778 E3F6 E4ED  F38E B27B 944E 3488 4E85
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]