On Wed, May 12, 2010 at 7:01 AM, Jonathan Nieder <jrnieder@xxxxxxxxx> wrote: > Tay Ray Chuan wrote: >> This is to avoid using private tags by the user in a clone of the git >> code repository, which may break certain machinery (eg. Makefile). > > Not to mention gitk: > > set git_version [join [lrange [split [lindex [exec git version] end] .] 0 2] .] > if {[package vcompare $git_version "1.6.1"] >= 0} { > > This requires ‘git version’ output to have the form > > introducing 1.2.3.otherstuff > > or there will be errors at startup time. Thanks for the heads-up, I'll put that in the patch message. >> After this patch, perhaps we could advertise somewhere to git hackers >> that tags beginning with "v" should be avoided. > > Maybe v[0-9]* would make this problem harder to trip. Oh, I didn't know character classes were allows. Sounds good. -- Cheers, Ray Chuan -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html