Re: [PATCH] gitk: Show notes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Kirill Smelkov venit, vidit, dixit 11.05.2010 10:26:
> If in git.git I do
> 
>     $ git notes add -m 'This makes status significantly slower with Dokko' \
>         ee6fc514
> 
> then `git log` shows the note...
> 

because --show-notes is the default...

> ... but unfortunately gitk does not.

... unless --pretty is given, and gitk uses --pretty.

But what is wrong with gitk --show-notes?

If you mean to adjust gitk's default to log's current default please say
so in the commit message. There's no need to include a longish sample
output for that.

Also, I don't think proc do_readcommit needs the notes. The other two
places use $args, so it might make sense to prepend --show-notes to the
arg list in a central place.

Michael
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]