On Tue, May 4, 2010 at 00:38, Bert Wesarg <bert.wesarg@xxxxxxxxxxxxxx> wrote: > Coloring the extended headers where done as a whole not per line. less with > option -R (which is the default from git) does not support this coloring > mode because of performance reasons. The -r option would be an alternative > but has problems with lines that are longer than the screen. Therefore > stick to the idiom to color each line separately. The problem is, that the > result of ill_metainfo() will also be used as an parameter to an external > diff driver, so we need to disable coloring in this case. > > Because coloring is now done inside fill_metainfo() we can simply add this > string to the diff header and therefore keep the last newline in the > extended header. This results also into the fact that the external diff > driver now gets this last newline too. Which is a change in behavior > but a good one. Ping. Regards, Bert -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html