Re: [PATCH/RFC] Hacky version of a glob() driven config include

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, May 8, 2010 at 4:18 PM, Jakub Narebski <jnareb@xxxxxxxxx> wrote:
>
> On Sat, 8 May 2010, Ping Yin wrote:
> > >
> > > But perhaps we can break backwards compatibility here.  I don't know...
> > >
> > I think we can. Because config file is not in repository, so if your
> > older git doesn't support it, you should not use this new syntax.
>
> Actually per-repository $GIT_DIR/config file *is* in repository... but
> is not distributed (it is not transferred on clone / fetch).
>
> The problem with breaking backwards compatibility is when repository is
> on shared filesystem (be it networked filesystem such as NFS or
> CIFS/Samba share, or portable USB (pen)drive), and can be accessed by
> different versions of git.

You are right, i missed this case.
However, If NFS is used, the git version is very likely the same. So i
think this case is not worth the effort to keep the backwards
compatibility.

>
> The '@INCLUDE = db_config.ini' is taken from OpenInteract2::Config::Ini.

I prefer "include foo" which is used by apache, and "@include foo"
which doesn't fail to parse when foo doesn't exist.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]