Re: [PATCH] Documentation/config.txt: Move GIT_NOTES_REWRITE_REF to notes.rewriteRef

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thomas Rast <trast@xxxxxxxxxxxxxxx> skreiv Wed, 05 May 2010 16:00:03 +0200

Leif Arne Storset wrote:
Was notes.rewrite. The environment variable refers to globs and refs, which are only mentioned by notes.rewriteRef; notes.rewrite is boolean.

Signed-off-by: Leif Arne Storset <lstorset@xxxxxxxxx>
---
This should be a trivial fix.

ACK and thanks for spotting this.  Putting it in the wrong place was
my fault.

I found the commit message confusing, though (my first thought was "we
have a notes.rewrite configuration variable?"), and you also have a

Yeah, I misread it as notes.rewrite.

way too long line there.  How about

Documentation/config.txt: GIT_NOTES_REWRITE_REF overrides notes.rewriteRef

  The documentation erroneously mentions the GIT_NOTES_REWRITE_REF
  override in the description of notes.rewrite.<command>.  Move it
  under notes.rewriteRef where it belongs.

Thanks, looks good. I suppose I should file a PATCH v2 now, it'll be along in a minute.

--
Leif Arne Storset
Core Technology Developer, Opera Software
Oslo, Norway
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]