On Tue, May 04, 2010 at 10:41:34PM +0200, René Scharfe wrote: > xdi_diff_outf() overrides the structure members of its last parameter, > ignoring any value that callers pass in. It's no surprise then that all > callers pass a pointer to an uninitialized structure. They also don't > read it after the call, so the parameter is neither used for input nor > for output. Turn it into a local variable of xdi_diff_outf(). Heh: http://article.gmane.org/gmane.comp.version-control.git/102861 So, Acked-by: Jeff King <peff@xxxxxxxx> -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html