Hi Josh, On Sun, May 02, 2010 at 10:57:40PM -0700, Joshua Juran wrote: > On May 2, 2010, at 6:39 PM, Gary V. Vaughan wrote: > > > On Sat, May 01, 2010 at 03:21:24AM -0700, Joshua Juran wrote: > >> On Apr 27, 2010, at 6:57 AM, Gary V. Vaughan wrote: > >> > >>> Index: b/remote.c > >>> =================================================================== > >>> --- a/remote.c > >>> +++ b/remote.c > >>> @@ -657,10 +657,9 @@ static struct refspec *parse_refspec_int > >>> > >>> int valid_fetch_refspec(const char *fetch_refspec_str) > >>> { > >>> - const char *fetch_refspec[] = { fetch_refspec_str }; > >>> struct refspec *refspec; > >>> > >>> - refspec = parse_refspec_internal(1, fetch_refspec, 1, 1); > >>> + refspec = parse_refspec_internal(1, &fetch_refspec_str, 1, 1); > >>> free_refspecs(refspec, 1); > >>> return !!refspec; > >>> } > >> > >> I'm the author of this patch. Agreed. > > I don't follow this list, and made this patch independently without > > reference to yours. > > You sent a different patch to the list, to which I responded[1] (both > to the list and to you directly) with one identical to the one shown > above, after which your subsequent patches included a change equal to > the one I suggested. If in fact you came up with it independently, > that's fine. I was just under the impression that you had adopted my > change. Apologies, yes you're quite right. Either my age, or the vast sea of patches for all the projects I'm porting at the moment somehow erased that important exchange from my memory. I hope I didn't cause offence, none was intended. Cheers, -- Gary V. Vaughan (gary@xxxxxxxxxxxxxxxxxx) -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html