On Sat, 2010-05-01 at 20:13 -0700, Junio C Hamano wrote: > I however wonder if we would want to be more helpful to the users to > diagnose this error by saying something here with error(), instead of just > letting the caller say "invalid --pretty format: %s". I suppose there's not really any sane reason why we wouldn't be able to die then and there. If we pass the original name into the recursive function, then the message could be: "invalid --pretty format: %s references an alias which points to itself" sound like okay wording? -- -- Will -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html