Re: [PATCH v3 2/5] pretty: make %H/%h/etc respect --abbrev[-commit]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 2010-05-01 at 20:13 -0700, Junio C Hamano wrote:
> I think it is a good change to make %h follow --abbrev, but %H should stay
> the full length no matter what (otherwise why would anybody use %H not %h?).

I could just as easily say "why would anyone pass --abbrev-commit unless
they actually wanted an abbreviated commit?". Synonyms are confusing,
but ignored parameters sound more confusing to me.

While I disagree that --abbrev-commit should have no effect whatsoever
when %H is involved, I agree that the link between %h and --abbrev is
more solid, so I will split %h respecting --abbrev into a separate
patch.

If the current behaviour is actually intentional, we should at least
update the documentation to say that %H is the "full commit hash",
rather than just the "commit hash".

-- 
-- Will

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]