On Tue, Apr 27, 2010 at 04:48:53PM +0200, Tor Arntsen wrote: > On Tue, Apr 27, 2010 at 16:39, Gary V. Vaughan > <git@xxxxxxxxxxxxxxxxxxxxxxxxx> wrote: > > On Tue, Apr 27, 2010 at 04:10:56PM +0200, Tor Arntsen wrote: > > >> but (ref. a patch I sent earlier, in its > >> first revision) I needed several other changes in order to compile on > >> 5.1 (I also needed those you have above), e.g. > >> -D_POSIX_C_SOURCE=1 NO_STRCASESTR = YesPlease NO_STRTOUMAX = YesPlease > >> NO_STRLCPY = YesPlease NO_MEMMEM = YesPlease NO_UINTMAX_T = YesPlease > >> NO_C99_FORMAT = YesPlease > >> and > >> NO_TCLTK = YesPlease > > > > Indeed, I don't mean to imply that this patch is all that is needed > > for OSF1, merely that the changes it contains benefit only OSF1. > > I see. In that case, as I have verified that those changes are indeed > necessary for OSF1: > > Acked-by: Tor Arntsen <tor@xxxxxxxxxxx> Wow, all these different pseudo-headers are starting to make my head spin! ;) > > Please bear in mind that I build using configure, and may have missed > > something necessary for a make-only driven build. > > Ah, Ok, that would explain it. I too found that with ./configure fewer > changes were needed. The patch I was working on I tested both with and > without configure. If your patch goes in I could follow up with the > changes needed for when not using configure, if you don't wish to > tacke that. Much appreciated, thank you. Unless it's a requirement for having these patches accepted upstream, then I'd rather not worry about the make only builds... I've mentioned elsewhere that the idea of reliable builds predicated on the idea that it is possible to maintain a static database of what options are required on each combination of libc/cc/os/patchlevel with any kind of reliability seems fundamentally flawed to me. Cheers, -- Gary V. Vaughan (gary@xxxxxxxxxxxxxxxxxx) -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html