On Fri, Mar 12, 2010 at 11:18:47AM +0200, Felipe Contreras wrote: > On Thu, Mar 11, 2010 at 6:32 PM, Gary V. Vaughan > <git@xxxxxxxxxxxxxxxxxxxxxxxxx> wrote: > > Unfortunately there are a still a lot of vendor compilers that choke > > when the last entry in an enum has a dangling comma (irix is one, and > > I can get you a list of which of our particular platforms exhibit this > > problem). > > I would appreciate that list if it's not much trouble. I take it back. I've been porting this patch forward from our builds of previous releases, and at some point it certainly was necessary (otherwise I wouldn't have written the patch)... and yet, all of our platforms are now able to compile a minimal test program in C. Either the offending vendor compilers have issued an update to accept the dangling comma syntax, or we have retired the machines that used to have this problem since I originally wrote the patch. It's notable that aCC (the HP C++ compiler) and CC (the SunOS C++ compiler) both issue a warning on dangling enum commas, but even they still compile successfully. Sorry for the noise, -- Gary V. Vaughan (gary@xxxxxxxxxxxxxxxxxx) -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html