Re: Please default to 'commit -a' when no changes were added

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 22 Apr 2010, Goswin von Brederlow wrote:

> I have never ever needed anything but
> 
> git commit -a
> git commit <file> <file> ...

When I was using CVS/SVN that's what I thought too.

> I do commit often and commit early and I start and finish one thing
> before I start another. Also I keep my files small so they do one thing
> and do it well. Overall that means I don't end up with multiple changes
> in a single file so I never need to cherry pick changes for a commit.

Good for you.  I'm not that disciplined. Hence I often end up working on 
more than one thing in parallel.  The index is just so incredibly useful 
in that case.  I'm also a big fan of 'git add -e'.

> So I don't think people should be forced to utilize the index. Imho that
> is a matter of the workflow people use. Some people work better with the
> index and some people (or projects) don't need it.

Exact.  It is therefore not progress to impose some inconvenience to one 
work flow in order to make another one easier.  And in this case we're 
talking about the difference between having to type an additional -a vs 
the risk of creating a commit with unexpected content.

> Alternatively an option to take all changes but only if the index is
> empty would be helpfull. Then people could define an alias for that or
> set the option in the config. Other than setting -a that would allow
> using an index when needed and commit everything in the normal case
> without having to change the command used to commit.

But you're proposing to change the semantics for that command.  And I 
also suspect that you're trying to make the index more hidden while what 
we're actually trying to do is to promote it.

What _you_ can do though, is this:

	git config --global alias.ci "commit -a"


Nicolas
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]