Michael J Gruber <git@xxxxxxxxxxxxxxxxxxxx> writes: > Currently, status gives a lot of hints even when advice.statusHints is > false. Change this so that all hints depend on the config varaible. > > Signed-off-by: Michael J Gruber <git@xxxxxxxxxxxxxxxxxxxx> > --- > wt-status.c | 12 ++++++------ > 1 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/wt-status.c b/wt-status.c > index 8ca59a2..38076ee 100644 > --- a/wt-status.c > +++ b/wt-status.c > @@ -625,7 +625,7 @@ void wt_status_print(struct wt_status *s) > if (s->show_untracked_files) > wt_status_print_untracked(s); > else if (s->commitable) > - fprintf(s->fp, "# Untracked files not listed (use -u option to show untracked files)\n"); > + fprintf(s->fp, "# Untracked files not listed%s\n", advice_status_hints ? " (use -u option to show untracked files)" : ""); This is a good change, but because you are losing the grep-ability with this patch (i.e. "grep -e 'not listed (use -u'" no longer works), I'd prefer to see this long line split into: fprintf(s->fp, "# Untracked files not listed%s\n", advice_status_hints ? " (use -u option to show untracked files)" : ""); Likewise for all the other changes. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html