Michael J Gruber wrote: > I don't think it's OK to exit or test_done > from within test_expect_something, is it? exit: the consequences are the same whether you’re in a test or not. Either way, it’s bad. I think the intent of that ‘exit’ was to make a good effort to set up for the next test and skip the test if that didn’t work, which is a bit old-fashioned. Emptying the index before the checkout would make it like that the setup should not fail even if some related bug resurfaces. test_done: not sure what would happen. Indeed, it doesn’t sound like a very sane thing to do. :) Jonathan -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html