Re: [PATCH v4 4/8] diff: Filter files that have changed only due to conversion changes.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 10 Apr 2010, Junio C Hamano wrote:

"Henrik Grubbström (Grubba)"  <grubba@xxxxxxxxxx> writes:

When the conversion filter for a file is changed, files may get listed
as modified even though the user has not made any changes to them.
This patch adds a configuration option 'core.refilterOnDiff', which
performs an extra renormalization pass to filter out such files.

Signed-off-by: Henrik Grubbström <grubba@xxxxxxxxxx>

Does this really have to be done for every invocation of diff?

But the problem feels very similar to the issue that touching the inode
information would make the cached stat information in the index invalid
and plumbing commands such as "diff-files" would report phantom changes.

True, storing this information in the index is a much better approach.

Of course you do not want to re-commit.  If however these files that are
unchanged from the end-user's point of view can be re-checked out safely,
then that would be similar to what "update-index --refresh" does for paths
that are stat-dirty.

I now have a tentative set of patches implementing this.

--
Henrik Grubbström					grubba@xxxxxxxxxx
Roxen Internet Software AB				grubba@xxxxxxxxx

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]