Hi,
On Fri, 20 Oct 2006, Jakub Narebski wrote:
> > But it does not change a thing. Since v0.99~653, we do not have any
> > collision check, even if compiled with COLLISION_CHECK.
>
> So why it is left in Makefile? Does defining this change a thing
> or not (in which case this section should be removed)?
It does not. The relevant parts in the code read like this:
sha1_filc.c:1442
/* FIXME!!! Collision check here ? */
sha1_file.c:1541
/*
* FIXME!!! We might do collision checking here, but we'd
* need to uncompress the old file and check it. Later.
*/
It was hoped that the people who actually care would implement that
functionality. (Note that in an earlier version, the check was
implemented, but would have to be different these days: pack files did not
exist then).
Ciao,
Dscho
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html