On 10/19/06, Josef Weidendorfer <Josef.Weidendorfer@xxxxxx> wrote:
For drawing the commit graph, previously every item got a pixmap created and set with item->setPixmap(), which is drawn by the standard implementation of QListView::paintCell(). Instead, this commit implements drawing of the graph directly in our own ListView::paintCell(). This gets rid of a lot of complex code to reset the pixmap of invisible items which was needed in large repositories before to not allocate huge amounts of memory. As we directly draw only the visible cells, it has no influence on performance (especially, as we got rid of pixmaps of invisible items before, and most often had to draw the graph anyway). Signed-off-by: Josef Weidendorfer <Josef.Weidendorfer@xxxxxx> ---
It looks sane. Thanks, I will apply this week-end.
In order to solve this, I looked at the code, and do not understand one thing: Why are you creating pixmaps for the graph, and do draw directly in paintCell() ?
The code to create pixmaps is older then the one to remove not visible pixmaps. When I added the latter I missed the opportunity to reformat exsisting code.
This patch does exactly this, and the next one does cleanup of code which is not used afterwards. If you like, I can comeup with a patch to directly draw the lines which would get rid of the original problem.
Yes, please. Thanks Marco - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html