Jakub Narebski <jnareb@xxxxxxxxx> writes: > Junio C Hamano wrote: >> Jakub Narebski <jnareb@xxxxxxxxx> writes: >> >> > How does special case of no value, i.e. >> > >> > [sendemail] >> > smtpuser >> >> That is not a special case; that is "boolean true". > > Well, it is "boolean true" *if* git-config is used with '--bool'. > > If git-send-email.perl used "git config -l -z" to read all its config > variables at once into hash, like gitweb.perl does in the > git_parse_project_config() subroutine, it would be able to distinguish > between those the case of no value: > > [sendemail] > smtpuser If sendemail is ever re-written in C and use git_config() API, the above will become boolean. Besides, even if you are sticking to sendemail.perl forever, you are still inventing another convention that "boolean true means no I don't want it". And it is clearly a lot less intuitive than "empty means no I don't want it", isn't it? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html