On Mon, Apr 12, 2010 at 9:35 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > @@ -1043,7 +1043,7 @@ X-Mailer: git-send-email $gitversion > defined $smtp_server_port ? "port=$smtp_server_port" : ""; > } > > - if (defined $smtp_authuser) { > + if (defined $smtp_authuser && $smtp_authuser ne '') { > > if (!defined $smtp_authpass) { > That would work but introduces a special case for smtpuser. Do you think users may wish to unset override other options too? Stefan -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html