Jens Lehmann <Jens.Lehmann@xxxxxx> writes: >>> This would give you an incorrect result if .git is a file that records >>> "gitdir: overthere" (see read_gitfile_gently() in setup.c); I would expect >>> it would become a fairly important ingredient if we ever enhance the >>> submodule support to add submodule that disappears/reappears in the >>> history. >> >> Right. This assumption is also present in add_submodule_odb() (used by >> show_submodule_summary()) and is_submodule_modified(), so i just reused >> it. This should be addressed in another patch. > > What about this one: Looks sensible to me. Thanks, and sorry for not catching this earlier. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html