On Fri, Apr 9, 2010 at 7:57 AM, Jonathan Nieder <jrnieder@xxxxxxxxx> wrote: > Nguyen Thai Ngoc Duy wrote: >> 2010/4/8 Jonathan Nieder <jrnieder@xxxxxxxxx>: > >>> A few of the earlier patches seem iffy, though they all start with a >>> correct idea. For example, one of them changes the semantics of >>> rev-parse --show-prefix without documenting it. So I have been looking >> >> You meant "rev-parse --git-dir"? > > I meant --show-prefix. ad36c84 (worktree setup: calculate prefix even > if no worktree is found, 2010-04-05) teaches rev-parse to produce a > nonempty prefix even when there is no workdir but didn’t update the > documentation: > > --show-prefix > When the command is invoked from a subdirectory, show the > path of the current directory relative to the top-level > directory. > > I suspect it’s a good change. Git ought to correctly honor relative > paths on the command line even when there is no work tree. But the > semantics are not clear any more --- when there is no top-level > directory, what is the prefix relative to? > > Probably my other words of warning were also too extreme. I have been > using a copy of git with nd/setup included, and aside from the > ls-remote problem I mentioned, I haven’t run into any trouble. OK. I thought it was expectation and did not check documentation. The assumption that $GIT_DIR stays at worktree's top directory is still around.. I'll rethink about this. -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html