Re: [PATCH] log: respect log.shownotes variable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thomas Rast <trast@xxxxxxxxxxxxxxx> writes:

> Looks useful to me, and the patch looks obviously correct.

It looked obviously correct and "because we can" not "because we need" to me.

> I think it is a useful addition, *especially* in the case where the
> configuration departs from the default.  Typing --show-notes=email
> --show-notes=commits just to avoid showing a third set of notes in
> refs/notes/bulky will get old fairly quickly...

I initially thought so until I realized that notes.displayRef is already
there.  But you are the one who did 894a9d3 (Support showing notes from
more than one notes tree, 2010-03-12) to add that feature, so I suspect
I forgot something while reaching my conclusion in [*1*].

[reference]

*1* Message-ID: <7vljczapzt.fsf@xxxxxxxxxxxxxxxxxxxxxxxx>
    $gmane/144286
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]