Re: [PATCH] ls-remote: default to 'origin' when no remote specified

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Apr 07, 2010 at 10:35:40PM -0700, Junio C Hamano wrote:

> Jeff King <peff@xxxxxxxx> writes:
> 
> > I don't really see a problem with this. The current behavior produces an
> > error, so it is not as if we are breaking somebody's workflow, and the
> > only sensible default is the same one used by the other commands.
> 
> I'd agree only if "the other commands" default to the same remote;
> otherwise as a plumbing, ls-remote should insist that the user be more
> explicit.
>
> The only odd-man out that would worry me is "git pull", as I expect
> everybody written in C would just use remote_get(NULL).

I agree, but I think they do all default to the same remote. Push and
fetch both use remote_get(NULL). Pull, AFAICT, just calls fetch and
picks out what to merge from FETCH_HEAD. Am I missing any others?

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]